Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node.js to PR CI image #69964

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Add Node.js to PR CI image #69964

merged 2 commits into from
Mar 16, 2020

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Mar 12, 2020

This should allow the rustdoc-js and rustdoc-js-std test suites to run automatically on PRs.

@ollie27
Add Node.js to PR CI image
965888a 
This should allow the `rustdoc-js` and `rustdoc-js-std` test suites to run automatically on PRs.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2020
@ollie27 ollie27 mentioned this pull request Mar 12, 2020
Merged
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Seems like a minimal and easy addition.

@bors
Copy link
Contributor

bors commented Mar 12, 2020

📌 Commit 965888a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2020
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-03-13T03:00:12.4567644Z ========================== Starting Command Output ===========================
2020-03-13T03:00:12.4572327Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/26f242ad-3649-4421-83ab-ceea657e3520.sh
2020-03-13T03:00:12.4572784Z 
2020-03-13T03:00:12.4576800Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-13T03:00:12.4594977Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69964/merge to s
2020-03-13T03:00:12.4598263Z Task         : Get sources
2020-03-13T03:00:12.4598552Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-13T03:00:12.4599091Z Version      : 1.0.0
2020-03-13T03:00:12.4599285Z Author       : Microsoft
---
2020-03-13T03:00:14.0744159Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-13T03:00:14.0755138Z ##[command]git config gc.auto 0
2020-03-13T03:00:14.0762252Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-13T03:00:14.0769202Z ##[command]git config --get-all http.proxy
2020-03-13T03:00:14.0781593Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69964/merge:refs/remotes/pull/69964/merge
---
2020-03-13T03:04:41.0693948Z Successfully built f9c65341da9d
2020-03-13T03:04:41.0734302Z Successfully tagged rust-ci:latest
2020-03-13T03:04:41.1291853Z Built container sha256:f9c65341da9da6e9ce41a33d4fb288be0fd2b9fceb4d271f3dde9f7a1d939711
2020-03-13T03:04:41.1313624Z Uploading finished image to https://rust-lang-ci-sccache2.s3.amazonaws.com/docker/9041edcbb3260794b5f5b7c0c974cb383cee0ad1e77904ea2d87638d1e6406e4b8588d2ee09aafda1cf5377735b979881194ff26f9e9c1214f81738fdfb59ebd
2020-03-13T03:05:25.3872855Z upload failed: - to s3://rust-lang-ci-sccache2/docker/9041edcbb3260794b5f5b7c0c974cb383cee0ad1e77904ea2d87638d1e6406e4b8588d2ee09aafda1cf5377735b979881194ff26f9e9c1214f81738fdfb59ebd An error occurred (InvalidAccessKeyId) when calling the CreateMultipartUpload operation: The AWS Access Key Id you provided does not exist in our records.
2020-03-13T03:05:25.8898322Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-03-13T03:05:25.8940188Z == clock drift check ==
2020-03-13T03:05:25.8956145Z   local time: Fri Mar 13 03:05:25 UTC 2020
2020-03-13T03:05:26.0594592Z   network time: Fri, 13 Mar 2020 03:05:26 GMT
---
2020-03-13T04:03:17.0917750Z .................................................................................................... 1700/9766
2020-03-13T04:03:21.8088472Z .................................................................................................... 1800/9766
2020-03-13T04:03:33.4945928Z ................................................................i................................... 1900/9766
2020-03-13T04:03:40.4178973Z .................................................................................................... 2000/9766
2020-03-13T04:03:55.0319131Z ......................................................iiiii......................................... 2100/9766
2020-03-13T04:04:05.6343735Z .................................................................................................... 2300/9766
2020-03-13T04:04:08.0168425Z .................................................................................................... 2400/9766
2020-03-13T04:04:11.3408080Z .................................................................................................... 2500/9766
2020-03-13T04:04:33.0463133Z .................................................................................................... 2600/9766
---
2020-03-13T04:07:06.4457912Z .........................i...............i.......................................................... 5000/9766
2020-03-13T04:07:15.8360361Z .................................................................................................... 5100/9766
2020-03-13T04:07:21.4298628Z ....................................................................i............................... 5200/9766
2020-03-13T04:07:27.3243948Z .................................................................................................... 5300/9766
2020-03-13T04:07:36.7754955Z .................................................ii.ii........i...i................................. 5400/9766
2020-03-13T04:07:45.0739369Z .................................................................................................... 5600/9766
2020-03-13T04:07:54.6440679Z .................................................................................................... 5700/9766
2020-03-13T04:08:00.9843859Z ........................................i........................................................... 5800/9766
2020-03-13T04:08:07.1852031Z .................................................................................................... 5900/9766
2020-03-13T04:08:07.1852031Z .................................................................................................... 5900/9766
2020-03-13T04:08:17.5573222Z .................................................................................................... 6000/9766
2020-03-13T04:08:26.4680782Z .................................ii...i..ii...........i............................................. 6100/9766
2020-03-13T04:08:43.2930922Z .................................................................................................... 6300/9766
2020-03-13T04:08:49.9976531Z .................................................................................................... 6400/9766
2020-03-13T04:08:49.9976531Z .................................................................................................... 6400/9766
2020-03-13T04:09:00.3483308Z ................................................................i..ii............................... 6500/9766
2020-03-13T04:09:25.7960396Z .................................................................................................... 6700/9766
2020-03-13T04:09:31.0927290Z ..............................................................i..................................... 6800/9766
2020-03-13T04:09:33.1603535Z .................................................................................................... 6900/9766
2020-03-13T04:09:35.1562997Z ................................................................................................i... 7000/9766
---
2020-03-13T04:11:13.4963220Z .................................................................................................... 7700/9766
2020-03-13T04:11:17.9394874Z .................................................................................................... 7800/9766
2020-03-13T04:11:23.7644502Z .................................................................................................... 7900/9766
2020-03-13T04:11:29.8240740Z ..............................................i..................................................... 8000/9766
2020-03-13T04:11:39.7310225Z ...............................................................................................iiiii 8100/9766
2020-03-13T04:11:45.5022306Z iiiii.i............................................................................................. 8200/9766
2020-03-13T04:11:59.5931266Z .................................................................................................... 8400/9766
2020-03-13T04:12:10.2294764Z .................................................................................................... 8500/9766
2020-03-13T04:12:22.0735310Z .................................................................................................... 8600/9766
2020-03-13T04:12:27.6314223Z .................................................................................................... 8700/9766
---
2020-03-13T04:14:46.4410584Z  finished in 7.364
2020-03-13T04:14:46.4411501Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-13T04:14:46.4884868Z 
2020-03-13T04:14:46.4885380Z running 179 tests
2020-03-13T04:14:49.3757592Z iiii......i...........ii..iiii....i....i...........i............i..i..................i....i........ 100/179
2020-03-13T04:14:51.8228032Z ....i.i.i...iii..iiiiiiiiiiiiiiii.......................i.ii...........ii......
2020-03-13T04:14:51.8234627Z 
2020-03-13T04:14:51.8234846Z  finished in 5.551
2020-03-13T04:14:51.8376495Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-13T04:14:52.0016543Z 
---
2020-03-13T04:14:53.8856797Z  finished in 2.047
2020-03-13T04:14:53.9036923Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-13T04:14:54.0596149Z 
2020-03-13T04:14:54.0596631Z running 9 tests
2020-03-13T04:14:54.0597863Z iiiiiiiii
2020-03-13T04:14:54.0599308Z 
2020-03-13T04:14:54.0602313Z  finished in 0.156
2020-03-13T04:14:54.0799661Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-13T04:14:54.2849485Z 
---
2020-03-13T04:15:13.9946494Z  finished in 19.914
2020-03-13T04:15:14.0173762Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-13T04:15:14.2076927Z 
2020-03-13T04:15:14.2078836Z running 115 tests
2020-03-13T04:15:27.4937330Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-03-13T04:15:29.1517562Z ...iiii.....ii.
2020-03-13T04:15:29.1519725Z 
2020-03-13T04:15:29.1523573Z  finished in 15.134
2020-03-13T04:15:29.1527174Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-13T04:15:29.1530950Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-03-13T04:28:30.8772949Z 
2020-03-13T04:28:30.8773794Z    Doc-tests core
2020-03-13T04:28:35.7982209Z 
2020-03-13T04:28:35.7983790Z running 2480 tests
2020-03-13T04:28:44.8503917Z ......iiiii......................................................................................... 100/2480
2020-03-13T04:28:54.1188376Z ....................................................................................ii.............. 200/2480
2020-03-13T04:29:15.4956368Z ...................i................................................................................ 400/2480
2020-03-13T04:29:15.4956368Z ...................i................................................................................ 400/2480
2020-03-13T04:29:25.4727506Z ........................................................................i..i..................iiii.. 500/2480
2020-03-13T04:29:41.9982942Z .................................................................................................... 700/2480
2020-03-13T04:29:50.7743653Z .................................................................................................... 800/2480
2020-03-13T04:29:59.0632971Z .................................................................................................... 900/2480
2020-03-13T04:30:07.4648276Z .................................................................................................... 1000/2480
---
2020-03-13T04:33:42.2913400Z 
2020-03-13T04:33:42.2914033Z running 1010 tests
2020-03-13T04:33:59.6066880Z i................................................................................................... 100/1010
2020-03-13T04:34:09.7657872Z .................................................................................................... 200/1010
2020-03-13T04:34:17.0356040Z ..................iii......i......i...i......i...................................................... 300/1010
2020-03-13T04:34:22.0869174Z .................................................................................................... 400/1010
2020-03-13T04:34:28.7331824Z ............................................i..i......................................ii............ 500/1010
2020-03-13T04:34:41.2465034Z .................................................................................................... 700/1010
2020-03-13T04:34:41.2465034Z .................................................................................................... 700/1010
2020-03-13T04:34:48.0552063Z ....................................iiii............................................................ 800/1010
2020-03-13T04:35:02.1155792Z .................................................................................................... 900/1010
2020-03-13T04:35:08.7553739Z ..........................................................iiii...................................... 1000/1010
2020-03-13T04:35:09.1818359Z test result: ok. 990 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-03-13T04:35:09.1818601Z 
2020-03-13T04:35:09.1929162Z  finished in 167.286
2020-03-13T04:35:09.1941501Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-13T04:53:27.7716939Z  finished in 39.745
2020-03-13T04:53:27.7975707Z Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-13T04:53:28.0422764Z 
2020-03-13T04:53:28.0423111Z running 210 tests
2020-03-13T04:53:59.9116293Z ......................i...ii.......................................................................i 100/210
2020-03-13T04:54:35.4083668Z ........................................iiiiii......i..............iii.............................. 200/210
2020-03-13T04:54:39.6572345Z test result: ok. 195 passed; 0 failed; 15 ignored; 0 measured; 0 filtered out
2020-03-13T04:54:39.6572647Z 
2020-03-13T04:54:39.6572798Z  finished in 71.859
2020-03-13T04:54:39.6584222Z doc tests for: /checkout/src/doc/rustdoc/src/advanced-features.md
---
2020-03-13T04:54:52.7861357Z module.js:549
2020-03-13T04:54:52.7861967Z     throw err;
2020-03-13T04:54:52.7862344Z     ^
2020-03-13T04:54:52.7862495Z 
2020-03-13T04:54:52.7863508Z Error: Cannot find module '/checkout/obj/src/tools/rustdoc-js-std/tester.js'
2020-03-13T04:54:52.7864042Z     at Function.Module._resolveFilename (module.js:547:15)
2020-03-13T04:54:52.7864456Z     at Function.Module._load (module.js:474:25)
2020-03-13T04:54:52.7864852Z     at Function.Module.runMain (module.js:693:10)
2020-03-13T04:54:52.7865274Z     at startup (bootstrap_node.js:188:16)
2020-03-13T04:54:52.7865616Z     at bootstrap_node.js:609:3
2020-03-13T04:54:52.7883143Z 
2020-03-13T04:54:52.7883143Z 
2020-03-13T04:54:52.7884071Z command did not execute successfully: "/usr/bin/node" "src/tools/rustdoc-js-std/tester.js" "x86_64-unknown-linux-gnu"
2020-03-13T04:54:52.7885800Z 
2020-03-13T04:54:52.7885887Z 
2020-03-13T04:54:52.7943016Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-03-13T04:54:52.7943409Z Build completed unsuccessfully in 1:45:53
2020-03-13T04:54:52.7943409Z Build completed unsuccessfully in 1:45:53
2020-03-13T04:54:52.7947355Z == clock drift check ==
2020-03-13T04:54:52.7963075Z   local time: Fri Mar 13 04:54:52 UTC 2020
2020-03-13T04:54:53.4021870Z   network time: Fri, 13 Mar 2020 04:54:53 GMT
2020-03-13T04:54:53.4028273Z == end clock drift check ==
2020-03-13T04:54:54.6598614Z 
2020-03-13T04:54:54.6663618Z ##[error]Bash exited with code '1'.
2020-03-13T04:54:54.6676722Z ##[section]Finishing: Run build
2020-03-13T04:54:54.6734960Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69964/merge to s
2020-03-13T04:54:54.6739467Z Task         : Get sources
2020-03-13T04:54:54.6739912Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-13T04:54:54.6740200Z Version      : 1.0.0
2020-03-13T04:54:54.6740399Z Author       : Microsoft
2020-03-13T04:54:54.6740399Z Author       : Microsoft
2020-03-13T04:54:54.6740730Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-13T04:54:54.6741100Z ==============================================================================
2020-03-13T04:54:55.9027263Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-13T04:54:55.9069605Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69964/merge to s
2020-03-13T04:54:55.9147259Z Cleaning up task key
2020-03-13T04:54:55.9148404Z Start cleaning up orphan processes.
2020-03-13T04:54:55.9313958Z Terminate orphan process: pid (4661) (python)
2020-03-13T04:54:55.9653085Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@ollie27
Copy link
Member Author

ollie27 commented Mar 13, 2020

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 13, 2020
@ollie27
Copy link
Member Author

ollie27 commented Mar 13, 2020

Seems like a minimal and easy addition.

If only. These test suites apparently never supported being run from a directory other than the source code root. I've pushed a commit to hopefully fix that.

cc @GuillaumeGomez

@ollie27 ollie27 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2020
@GuillaumeGomez
Copy link
Member

I went to the quickest but this is really nice to make those tests being able to run with a given output folder. Were you able to test it locally without issues? If so, r=me.

Again, thanks a lot for making them easier to run!

@ollie27
Copy link
Member Author

ollie27 commented Mar 15, 2020

Were you able to test it locally without issues?

Yeah, but more importantly the logs from the PR build: https://dev.azure.com/rust-lang/rust/_build/results?buildId=23190&view=logs&j=0230d20d-e0df-5b62-a6ec-fad0f9c3c3d5&t=a6ad31e5-07ba-5fd6-c0b6-53535f688400&l=3574 show that it successfully ran the tests.

@bors r=Mark-Simulacrum,GuillaumeGomez

@bors
Copy link
Contributor

bors commented Mar 15, 2020

📌 Commit 3f58ab6 has been approved by Mark-Simulacrum,GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#69964 - ollie27:ci_nodejs, r=Mark-Simulacru…
dd5c112 
…m,GuillaumeGomez

Add Node.js to PR CI image

This should allow the `rustdoc-js` and `rustdoc-js-std` test suites to run automatically on PRs.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 15, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 16, 2020
Merged
bors added a commit that referenced this pull request Mar 16, 2020
@bors
Auto merge of #70034 - Dylan-DPC:rollup-5yg771j, r=Dylan-DPC
97eda01 
Rollup of 8 pull requests

Successful merges:

 - #69686 (Use `pprust` to print attributes in rustdoc)
 - #69858 (std: on Windows, use GetSystemTimePreciseAsFileTime if it is available)
 - #69917 (Cleanup E0412 and E0422)
 - #69964 (Add Node.js to PR CI image)
 - #69992 (Block version-specific docs from search engines)
 - #69995 (Add more context to the literal overflow message)
 - #69998 (Add long error explanation for E0634)
 - #70014 (Small fixes in rustdoc book)

Failed merges:

r? @ghost
@bors bors merged commit fdb5df0 into rust-lang:master Mar 16, 2020
@ollie27 ollie27 deleted the ci_nodejs branch March 16, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ollie27 @rust-highfive @Mark-Simulacrum @bors @GuillaumeGomez